fix: Update RedisCluster to use redis-py official implementation (#2554)

* switch to using redis cluster in redis-py Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix dependencies Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Update py3.7-ci-requirements.txt Signed-off-by: Felix Wang <wangfelix98@gmail.com> * update 3.10 requirements Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix dependencies to address issues Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Co-authored-by: Felix Wang <wangfelix98@gmail.com>
feast-dev · Apr 15, 2022 · ce5606f · ce5606f
1 parent 753bd88
commit ce5606f
Show file tree

Hide file tree

Showing 9 changed files with 425 additions and 685 deletions.
diff --git a/sdk/python/feast/infra/online_stores/redis.py b/sdk/python/feast/infra/online_stores/redis.py
@@ -42,7 +42,7 @@
 
 try:
     from redis import Redis
-    from rediscluster import RedisCluster
+    from redis.cluster import ClusterNode, RedisCluster
 except ImportError as e:
     from feast.errors import FeastExtrasDependencyImportError
 
@@ -164,7 +164,9 @@ def _get_client(self, online_store_config: RedisOnlineStoreConfig):
                 online_store_config.connection_string
             )
             if online_store_config.redis_type == RedisType.redis_cluster:
-                kwargs["startup_nodes"] = startup_nodes
+                kwargs["startup_nodes"] = [
+                    ClusterNode(**node) for node in startup_nodes
+                ]
                 self._client = RedisCluster(**kwargs)
             else:
                 kwargs["host"] = startup_nodes[0]["host"]