Skip to content

Commit

Permalink
Fix Makefile to properly create the ECR_VERSION from the VERSION argu…
Browse files Browse the repository at this point in the history
…ment (#2123)

Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
adchia committed Dec 9, 2021
1 parent 6758139 commit db336ea
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,14 @@ build-ci-docker:
# Note, we use underscores instead of periods in the version name since ECR doesn't support periods. We automatically
# pull from Docker Hub and push to ECR.
push-feature-server-aws-docker:
ECR_VERSION=`echo "$(VERSION)" | sed 's/[.]/_/g'`
docker push $(REGISTRY)/feature-server-aws:$(ECR_VERSION)
ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \
docker push $(REGISTRY)/feature-server-aws:$$ECR_VERSION

build-feature-server-aws-docker:
ECR_VERSION=`echo "$(VERSION)" | sed 's/[.]/_/g'`
docker build --build-arg VERSION=${ECR_VERSION} \
-t $(REGISTRY)/feature-server-aws:${ECR_VERSION} \
-f sdk/python/feast/infra/feature_servers/aws_lambda/Dockerfile .
ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \
docker build --build-arg VERSION=$$ECR_VERSION \
-t $(REGISTRY)/feature-server-aws:$$ECR_VERSION \
-f sdk/python/feast/infra/feature_servers/aws_lambda/Dockerfile .

push-feature-transformation-server-docker:
docker push $(REGISTRY)/feature-transformation-server:$(VERSION)
Expand Down

0 comments on commit db336ea

Please sign in to comment.