Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up entity dataframes or temporary tables by default #1902

Closed
woop opened this issue Sep 23, 2021 · 0 comments · Fixed by #1916
Closed

Clean up entity dataframes or temporary tables by default #1902

woop opened this issue Sep 23, 2021 · 0 comments · Fixed by #1916
Labels
good first issue Good for newcomers kind/feature New feature or request priority/p1

Comments

@woop
Copy link
Member

woop commented Sep 23, 2021

Is your feature request related to a problem? Please describe.
Currently when a user runs get_historical_features() Feast will upload or create an entity dataframe in the offline store. Feast will then build a training dataset and return that to the user. Feast does not clean up the temporary tables, but often sets an expiry. This means that a data warehouse constantly has a set of temporary tables waiting to expire.

Describe the solution you'd like
Delete entity dataframe tables after a training dataset has been created (as well as other temporary tables in the creation process).
@woop woop added kind/feature New feature or request good first issue Good for newcomers priority/p1 labels Sep 23, 2021
@felixwang9817 felixwang9817 mentioned this issue Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature New feature or request priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete tables felixwang9817/feast
1 participant
@woop