Delete tables #1916
Delete tables #1916
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
requested review from
achals,
adchia,
tsotnet,
woop and
a team
as code owners
|
|
||
| def to_sql(self) -> str: | ||
| """ | ||
| Returns the SQL query that will be executed in BigQuery to build the historical feature table. | ||
| """ | ||
| return self.query | ||
| with self._query_generator() as query: |
There was a problem hiding this comment.
Note: technically the query generated here will not be the exact query used to build the historical feature table, since the randomly generated table name will be different. I couldn't think of a better way to handle to_sql given that we switched to a context manager - open to suggestions.
There was a problem hiding this comment.
Hmmm in that case we run think we should either return a sql strinv with the table name a parameter that canbe filled the, or we should accept it as a param forthr to_sql method. As it stands a full SQL string that does is not expected to execute correctly seems like a bug
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
- Coverage 82.95% 82.35% -0.61%
==========================================
Files 96 96
Lines 7359 7454 +95
==========================================
+ Hits 6105 6139 +34
- Misses 1254 1315 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Currently, entity dataframes are uploaded to Bigquery and Redshift and are not always cleaned up properly. This PR ensures they are always cleaned up.
Which issue(s) this PR fixes:
Fixes #1902
Does this PR introduce a user-facing change?: