Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CI #2

Closed
pradithya opened this issue Dec 10, 2018 · 5 comments
Closed

Create CI #2

pradithya opened this issue Dec 10, 2018 · 5 comments

Comments

@pradithya
Copy link
Collaborator

No description provided.

@woop
Copy link
Member

woop commented Dec 14, 2018

What do we want to run within CI? Are we just running tests and building binaries and docker images?

@pradithya
Copy link
Collaborator Author

Yes, that's pretty much it for starter. Should also includes publishing the artifacts.

@woop
Copy link
Member

woop commented Jan 1, 2019

I'm setting up Terraform configuration for the infrastructure, and Prow for monitoring GitHub. I think using Argo for running the tests would probably be the easiest long term, since that is what Kubeflow is using.

Before we get there we also need test scripts that can be executed from the stages in CI.

@woop
Copy link
Member

woop commented Jan 2, 2019

@tims @pradithya Can we discuss the range of tests that we require for Feast in the short term?

We will have 1 primary test cluster within our kf-feast GCP project. That cluster will be used to orchestrate all testing, and can even run some limited testing itself (unit tests and builds).

Other than that, we need to make a decision in terms of how we want to lay out the rest of the test systems. As I see it, we have three options:

  1. Have a dedicated and reusable setup to run tests in the GCP project. This means we will have a single Kubernetes cluster that is long running, and also any other infra that is required like Kafka, Pub/Sub, buckets, BQ. Only 1 run of tests can be executed at a time, and probably sequentially. We can tear down and clear all the resources after each run, and install them again at the start of new runs.
  2. We dynamically provision new resources for each run. Meaning we will probably have a startup container that creates a new Feast deployment and runs all tests. This would allow us to run tests in parallel, but this would consume have a longer startup time. It would also require some thinking in terms of how we want to isolate each of these systems. For example, isolating BQ datasets.
  3. We can also take a hybrid approach. One in which we reuse the same GCP resources for parallel runs, but we isolate the runs within namespaces inside the Kubernetes cluster. This would not be 100% deterministic though, since one run can influence the performance of another.

#22

@woop
Copy link
Member

woop commented Jan 4, 2019

Closing this after base CI has been set up.

@woop woop closed this as completed Jan 4, 2019
@woop woop unassigned tims May 16, 2020
Yanson pushed a commit to Yanson/feast that referenced this issue Jul 29, 2020
qooba pushed a commit to qooba/feast that referenced this issue May 9, 2021
dmartinol pushed a commit to dmartinol/feast that referenced this issue May 15, 2024
tsisodia10 pushed a commit to tsisodia10/feast that referenced this issue Jul 23, 2024
# This is the 1st commit message:

chore: Bump ws from 7.5.6 to 7.5.10 in /ui (feast-dev#4292)


# This is the commit message feast-dev#2:

Remove metric checks

Signed-off-by: Twinkll Sisodia <tsisodia@redhat.com>

# This is the commit message feast-dev#3:

Draft different md file

# This is the commit message feast-dev#4:

Refine opentelemetry.md

# This is the commit message feast-dev#5:

Refine opentelemetry.md

# This is the commit message feast-dev#6:

Refine opentelemetry.md

# This is the commit message feast-dev#7:

Refine opentelemetry.md
tsisodia10 pushed a commit to tsisodia10/feast that referenced this issue Jul 23, 2024
# This is the 1st commit message:

chore: Bump ws from 7.5.6 to 7.5.10 in /ui (feast-dev#4292)


# This is the commit message feast-dev#2:

Remove metric checks

Signed-off-by: Twinkll Sisodia <tsisodia@redhat.com>

# This is the commit message feast-dev#3:

Draft different md file

# This is the commit message feast-dev#4:

Refine opentelemetry.md

# This is the commit message feast-dev#5:

Refine opentelemetry.md

# This is the commit message feast-dev#6:

Refine opentelemetry.md

# This is the commit message feast-dev#7:

Refine opentelemetry.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants