Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast ui -h 0.0.0.0 -p 5000 will lead to XHR calls to target http://0.0.0.0:5000/.... #2872

Closed
jerive opened this issue Jun 28, 2022 · 4 comments

Comments

@jerive
Copy link
Contributor

jerive commented Jun 28, 2022

Expected Behavior

XHR call base URL should either be configurable, either be / by default

Current Behavior

The only way to configure XHR base calls is through -h or -p CLI options, which leads to issues when e.g., running the command in a docker container

Steps to reproduce

Run feast ui

Specifications

Possible Solution

Add an option to configure the base XHR URIs ?

@adchia
Copy link
Collaborator

adchia commented Jun 28, 2022

what version of Feast are you running? This should have been resolved in one of the recent releases

@jerive
Copy link
Contributor Author

jerive commented Jun 28, 2022

Feast 0.21.3 (0.22 is not on pypi yet)

@adchia
Copy link
Collaborator

adchia commented Jun 29, 2022

hmm this seems strange. I'm not able to reproduce that.

The feast ui command spins up a ui_server which makes relative calls to /registry (see https://github.com/feast-dev/feast/blob/master/sdk/python/feast/ui_server.py#L65 which configures this). Was able to e.g. run it and see the UI from a Google colab by hitting the public endpoint of the node, so didn't seem like it was hitting 0.0.0.0.

This definitely used to be an issue prior to Feast 0.21.3, but was fixed by #2753.

If you're able to reproduce it on 0.21.3, any chance you could help troubleshoot since I can't reproduce?

@jerive
Copy link
Contributor Author

jerive commented Jun 30, 2022

Indeed, it is fixed at least in feast 0.22
Thanks a lot

@jerive jerive closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants