Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made URL to registry relative, fixes #2731 #2753

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

creativedutchmen
Copy link
Contributor

Instead of having the URL to the registry be absolute (default to 0.0.0.0:8888), use a relative path. This means there's no SSL issues when putting the UI behind a SSL proxy, nor will it try to load it from localhost. This change allows the UI to be deployed to a central location.

Fixes #2731

Signed-off-by: Huib Keemink <huib.keemink@jedlix.com>
@creativedutchmen creativedutchmen changed the title Made URL to registry relative, fixes #2731 fix: Made URL to registry relative, fixes #2731 Jun 2, 2022
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, creativedutchmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #2753 (f114146) into master (0cf3c92) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   80.44%   80.40%   -0.04%     
==========================================
  Files         171      171              
  Lines       14571    14571              
==========================================
- Hits        11721    11716       -5     
- Misses       2850     2855       +5     
Flag Coverage Δ
integrationtests 70.87% <ø> (-0.33%) ⬇️
unittests 59.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/ui_server.py 23.91% <ø> (ø)
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 91.30% <0.00%> (-4.35%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.14% <0.00%> (-0.78%) ⬇️
.../integration/offline_store/test_feature_logging.py 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf3c92...f114146. Read the comment docs.

@adchia adchia merged commit 44a3f05 into feast-dev:master Jun 2, 2022
@creativedutchmen creativedutchmen deleted the bugfix/2731-remote-ui branch June 3, 2022 07:21
adchia pushed a commit that referenced this pull request Jun 13, 2022
Signed-off-by: Huib Keemink <huib.keemink@jedlix.com>
adchia pushed a commit that referenced this pull request Jun 13, 2022
## [0.21.3](v0.21.2...v0.21.3) (2022-06-13)

### Bug Fixes

* Change online UI schema field to be optional ([#2766](#2766)) ([e6edb58](e6edb58)), closes [#2719](#2719)
* Made URL to registry relative, fixes [#2731](#2731) ([#2753](#2753)) ([a66aea8](a66aea8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access data in Feast UI when deployed to remote instance
4 participants