-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change online UI schema field to be optional #2766
Conversation
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (feast-dev#2719). Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 80.56% 80.50% -0.07%
==========================================
Files 173 173
Lines 15093 15093
==========================================
- Hits 12160 12150 -10
- Misses 2933 2943 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia, dvanbrug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (#2719). Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
What this PR does / why we need it:
Change the
online
field in feastFeatureViews schema to be optional.This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the
online
tag.
Which issue(s) this PR fixes:
Fixes #2719