Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change online UI schema field to be optional #2766

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

dvanbrug
Copy link
Contributor

@dvanbrug dvanbrug commented Jun 7, 2022

What this PR does / why we need it:
Change the online field in feastFeatureViews schema to be optional.
This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the online
tag.

Which issue(s) this PR fixes:

Fixes #2719

Change the `online` field in feastFeatureViews schema to be optional.
This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the `online`
tag (feast-dev#2719).

Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
@dvanbrug dvanbrug changed the title Change online UI schema field to be optional fix: Change online UI schema field to be optional Jun 7, 2022
@achals
Copy link
Member

achals commented Jun 7, 2022

/ok-to-test
/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #2766 (d9b5e94) into master (da763c6) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   80.56%   80.50%   -0.07%     
==========================================
  Files         173      173              
  Lines       15093    15093              
==========================================
- Hits        12160    12150      -10     
- Misses       2933     2943      +10     
Flag Coverage Δ
integrationtests 70.45% <ø> (-0.36%) ⬇️
unittests 59.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/unit/test_feature_validation.py 66.66% <0.00%> (-16.67%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 92.85% <0.00%> (-3.58%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...k/python/tests/unit/test_on_demand_feature_view.py 67.18% <0.00%> (-1.57%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.14% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da763c6...d9b5e94. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, dvanbrug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia merged commit d25e8d4 into feast-dev:master Jun 8, 2022
adchia pushed a commit that referenced this pull request Jun 13, 2022
Change the `online` field in feastFeatureViews schema to be optional.
This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the `online`
tag (#2719).

Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia pushed a commit that referenced this pull request Jun 13, 2022
## [0.21.3](v0.21.2...v0.21.3) (2022-06-13)

### Bug Fixes

* Change online UI schema field to be optional ([#2766](#2766)) ([e6edb58](e6edb58)), closes [#2719](#2719)
* Made URL to registry relative, fixes [#2731](#2731) ([#2753](#2753)) ([a66aea8](a66aea8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI fails to run correctly on project with offline Featureviews
5 participants