-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiCustomLink causing error on feast-ui NPM package #3794
Comments
Based on the reply on react-router On const returnToUrl = new URL(to, window.location.origin);
navigate({
pathname: returnToUrl.pathname,
search: returnToUrl.searchParams.toString()
}); |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@pcminh0505 - I have tested this issue with the most recent feast UI and i could not replicate the issue. Please let me know if you can replicate the issue again. |
Can you check my repo setup via this link? https://github.com/pcminh0505/feast-infra/tree/master/your-feast-ui . I also include the screen recording here: https://vimeo.com/933219632?share=copy Thanks a lot! |
Hi @pcminh0505, Thank you for sharing the source code and video. It became little easy to replicate the issue on my local. After investigating the dependencies and comparing with actual feast UI project dependencies realized you are using latest version of react-roter-dom than dependency version of feast-ui. feast-ui is using Seems like react-router version 6.22.3 is having issues so if you update that version to 6.2.1 then i don't see the issue. There are too many places to modify the navigate method to apply the fix of the future react dom version. We can update the code whenever we update the react router version in future. |
Hi @lokeshrangineni , I tried to downgrade the I'm happy if you close this issue. |
…st UI As noted in feast-dev#3794, Feast UI is not compatible with latest react-router-dom versions, more precisely from 6.4.0 onwards. Limit react-router-dom version to a compatible range to avoid the runtime errors mentioned in the issue when installing peer dependencies without specifying exact versions. After setting the restricted versions, `yarn install` updated `react-router-dom` to the latest compatible version 6.3.0. It should be a minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630), and I didn't notice anything not working in the UI after it. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
…st UI (#4556) As noted in #3794, Feast UI is not compatible with latest react-router-dom versions, more precisely from 6.4.0 onwards. Limit react-router-dom version to a compatible range to avoid the runtime errors mentioned in the issue when installing peer dependencies without specifying exact versions. After setting the restricted versions, `yarn install` updated `react-router-dom` to the latest compatible version 6.3.0. It should be a minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630), and I didn't notice anything not working in the UI after it. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
…st UI (feast-dev#4556) As noted in feast-dev#3794, Feast UI is not compatible with latest react-router-dom versions, more precisely from 6.4.0 onwards. Limit react-router-dom version to a compatible range to avoid the runtime errors mentioned in the issue when installing peer dependencies without specifying exact versions. After setting the restricted versions, `yarn install` updated `react-router-dom` to the latest compatible version 6.3.0. It should be a minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630), and I didn't notice anything not working in the UI after it. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Hi, I'm new to Feast and Feast UI, trying to construct a React app using your
feast-ui
package to display multiple feature repos on the UI.It seems to me that the current NPM package of
feast-ui
is having some problems with the custom componentEuiCustomLink
that fails to parse the pathExpected Behavior
Here's the UI with the
feast ui
SDK inside one feature_repo project. I'm using the one inside yourfeast/ui/feature_repo
folder on credit_scoring. There was no problem when I clicked Feature View/credit_historyIt is Worth noticing that the date_added =
2022-02-6
is related to the NPM package issue.Current Behavior
When I tried replicating with a React app, managing multiple projects (later will show the
projects-list.json
), it prompted the error that could not query the time in the path. TheData Sources
andEntities
tabs are fine, only for theFeature Views
andFeature Services
that you're applying some filter.Steps to reproduce
feast apply
inside the feast/ui/feature_repo to get theregistry.db
fileregistry.db
file to the/public
directory of React appprojects-list.json
file as:<FeastUI />
as a default component inindex.js
file and runyarn start
Specifications
I tried both using the latest dependency packages version and downgrade to meet the exact version in the
feast/ui
repo, but none of them worked.Possible Solution
I think the error prompted quite clearly that there's an issue with the
EuiCustomLink
. I hope this bug report can help you investigate it for the official release (as I know it's still [BETA] version) on the current implementation ofreact-router-dom
andEuiLink
Thanks for this great project. Looking forward to your response soon!
The text was updated successfully, but these errors were encountered: