Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvement - Marking username and password field of OidcAuthConfig model optional #4457

Open
lokeshrangineni opened this issue Aug 28, 2024 · 0 comments
Labels
kind/feature New feature or request

Comments

@lokeshrangineni
Copy link
Contributor

lokeshrangineni commented Aug 28, 2024

This issue is created from the conversation.

The class OidcAuthConfig is having username, password and client_secret as mandatory. OIDC server side code is not using username and password so it is forcing server side code to pass the values. One of the proposal is to create separate model for oidc server and client. We need to evaluate all the util methods if it is going to impact in any other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant