-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Making username and password fields in OidcAuthModel as mandatory onl… #4460
refactor: Making username and password fields in OidcAuthModel as mandatory onl… #4460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update according to suggested changes
…et fields are required for oidc client configuration Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
d8e36cf
to
bb95073
Compare
…et fields are required for oidc client configuration Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
…' into feature/optional-oidc-username-pwd
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
I have incorporated all the code review comments. Please take a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
…' into feature/optional-oidc-username-pwd
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
Added separate model for OidcClient side so that username and password is not required for server side.
What this PR does / why we need it:
class OidcAuthConfig is having username and password as mandatory. OIDC server side code is not using username and password so it is forcing server side code to pass the values. One of the proposal is to create separate model for oidc server and client. We need to evaluate all the util methods if it is going to impact in any other way.
Which issue(s) this PR fixes:
#4457