refactor: Making username and password fields in OidcAuthModel as mandatory onl… #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokeshrangineni
changed the title
lokeshrangineni
commented
Aug 29, 2024
dmartinol
reviewed
Aug 30, 2024
dmartinol
reviewed
Aug 30, 2024
dmartinol
reviewed
Aug 30, 2024
dmartinol
reviewed
Aug 30, 2024
dmartinol
reviewed
Aug 30, 2024
dmartinol
suggested changes
Aug 30, 2024
…et fields are required for oidc client configuration Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
lokeshrangineni
force-pushed
the
feature/optional-oidc-username-pwd
branch
from
d8e36cf
to
bb95073
Compare
…et fields are required for oidc client configuration Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
…' into feature/optional-oidc-username-pwd
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
I have incorporated all the code review comments. Please take a look again. |
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
…' into feature/optional-oidc-username-pwd
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
dmartinol
reviewed
Sep 4, 2024
Signed-off-by: Lokesh Rangineni <19699092+lokeshrangineni@users.noreply.github.com>
jeremyary
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added separate model for OidcClient side so that username and password is not required for server side.
What this PR does / why we need it:
class OidcAuthConfig is having username and password as mandatory. OIDC server side code is not using username and password so it is forcing server side code to pass the values. One of the proposal is to create separate model for oidc server and client. We need to evaluate all the util methods if it is going to impact in any other way.
Which issue(s) this PR fixes:
#4457