Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow entities and features to be updated #1105

Merged

Conversation

terryyylim
Copy link
Member

Signed-off-by: Terence terencelimxp@gmail.com

What this PR does / why we need it:
As we're moving towards supporting deletion of feature tables, this is a step towards it by allowing changes to:

  • the entities in a feature table
  • the features and their types in a feature table

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Users can now update their entities and features in a feature table.

Signed-off-by: Terence <terencelimxp@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Oct 29, 2020

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants