Configurable materialization destination for view in BigQuerySource #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
khorshuheng
approved these changes
Nov 30, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
pyalex
added a commit
that referenced
this pull request
Dec 4, 2020
…1201) * configurable materialization destination Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * use materialization options in batch ingestion Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * fix no default value Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com
What this PR does / why we need it:
When using BQ view as source for historical retrieval and batch ingestion there could be an issue with permissions. Since spark-bq connector first needs to materialize view before read it - it requires "create table" access, which could be problematic when view is located in different / uncontrolled project.
This PR introduces two configuration options
that will be passed to both ingestion & historical retrieval jobs. This will make possible to use project / dataset where feast project has permissions to create table.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: