Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Table is not being update when only max_age was changed #1208

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Dec 1, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
Bug in FeatureTale.equals method that should check whether FeatureTable was changed. If only max age was updated - FeatureTable is not saved.

Does this PR introduce a user-facing change?:


Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex pyalex requested a review from zhilingc as a code owner December 1, 2020 10:00
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-aws 1a4d38a link /test test-end-to-end-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex pyalex merged commit 3826bd9 into feast-dev:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants