Refactor staging client uploader and use it in EMR launcher #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
|
/kind housekeeping |
oavdeev
force-pushed
the
use-staging-client-for-emr
branch
4 times, most recently
from
1e8a81a
to
5f45ef2
Compare
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
oavdeev
force-pushed
the
use-staging-client-for-emr
branch
from
5f45ef2
to
0a2b6ec
Compare
|
/lgtm |
pyalex
approved these changes
Dec 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It makes EMR launcher use the standard uploader from
feast.staging. Since EMR launcher relied on some functionality that didn't exist in the staging uploader, I had to update the staging uploader to support it.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: