Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply grpc tracing interceptor on online serving #1242

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

khorshuheng
Copy link
Collaborator

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
This is a back port of #1212, excluding client side change. Implementation of grpc tracing interceptor on golang and java client will be on a separate PR.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Two new tags have been added to Jaeger Tracing spans, for online serving: number of entities and features in request.

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Dec 23, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 04d2b47 into feast-dev:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants