Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry refreshing and caching #1431

Merged
merged 8 commits into from
Apr 3, 2021
Merged

Add registry refreshing and caching #1431

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25d9c1a
Fail on missing registry and add cache test
woop Apr 2, 2021
e641232
Add basic support for caching to Registry
woop Apr 2, 2021
2a3a7f3
Add additional tests to registry caching
woop Apr 2, 2021
09f515c
Fix linting errors
woop Apr 2, 2021
4cb295b
Add incremental configuration to metadata store config
woop Apr 2, 2021
d97fb36
Add comment to refresh_registry()
woop Apr 2, 2021
35f06b1
Add comments
woop Apr 2, 2021
d70b3a0
Don't allow simultanous cache loads
woop Apr 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added metadata.db
View file
Open in desktop
Binary file not shown.
62 changes: 41 additions & 21 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from collections import defaultdict
from datetime import datetime
from datetime import datetime, timedelta
from pathlib import Path
from typing import Any, Dict, List, Optional, Tuple, Union

Expand Down Expand Up @@ -51,6 +51,7 @@ class FeatureStore:

config: RepoConfig
repo_path: Optional[str]
_registry: Registry

def __init__(
self, repo_path: Optional[str] = None, config: Optional[RepoConfig] = None,
Expand All @@ -72,15 +73,31 @@ def __init__(
),
)

metadata_store_config = self.config.get_metadata_store_config()
self._registry = Registry(
registry_path=metadata_store_config.path,
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
)

@property
def project(self) -> str:
return self.config.project

def _get_provider(self) -> Provider:
return get_provider(self.config)

def _get_registry(self) -> Registry:
return Registry(self.config.metadata_store)
def refresh_registry(self):
"""Fetches and caches a copy of the feature registry in memory.

Explicitly calling this method makes it possible for methods like get_online_features to use cached registry
state instead of retrieving the registry state at request-time, thus reducing latency."""
woop marked this conversation as resolved.
Show resolved Hide resolved

metadata_store_config = self.config.get_metadata_store_config()
self._registry = Registry(
registry_path=metadata_store_config.path,
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
)
self._registry.refresh()

def list_entities(self) -> List[Entity]:
"""
Expand All @@ -89,7 +106,7 @@ def list_entities(self) -> List[Entity]:
Returns:
List of entities
"""
return self._get_registry().list_entities(self.project)
return self._registry.list_entities(self.project)

def list_feature_views(self) -> List[FeatureView]:
"""
Expand All @@ -98,7 +115,7 @@ def list_feature_views(self) -> List[FeatureView]:
Returns:
List of feature views
"""
return self._get_registry().list_feature_views(self.project)
return self._registry.list_feature_views(self.project)

def get_entity(self, name: str) -> Entity:
"""
Expand All @@ -111,7 +128,7 @@ def get_entity(self, name: str) -> Entity:
Returns either the specified entity, or raises an exception if
none is found
"""
return self._get_registry().get_entity(name, self.project)
return self._registry.get_entity(name, self.project)

def get_feature_view(self, name: str) -> FeatureView:
"""
Expand All @@ -124,7 +141,7 @@ def get_feature_view(self, name: str) -> FeatureView:
Returns either the specified feature view, or raises an exception if
none is found
"""
return self._get_registry().get_feature_view(name, self.project)
return self._registry.get_feature_view(name, self.project)

def delete_feature_view(self, name: str):
"""
Expand All @@ -133,7 +150,7 @@ def delete_feature_view(self, name: str):
Args:
name: Name of feature view
"""
return self._get_registry().delete_feature_view(name, self.project)
return self._registry.delete_feature_view(name, self.project)

def apply(self, objects: List[Union[FeatureView, Entity]]):
"""Register objects to metadata store and update related infrastructure.
Expand Down Expand Up @@ -166,15 +183,14 @@ def apply(self, objects: List[Union[FeatureView, Entity]]):

# TODO: Add locking
# TODO: Optimize by only making a single call (read/write)
registry = self._get_registry()

views_to_update = []
for ob in objects:
if isinstance(ob, FeatureView):
registry.apply_feature_view(ob, project=self.config.project)
self._registry.apply_feature_view(ob, project=self.config.project)
views_to_update.append(ob)
elif isinstance(ob, Entity):
registry.apply_entity(ob, project=self.config.project)
self._registry.apply_entity(ob, project=self.config.project)
else:
raise ValueError(
f"Unknown object type ({type(ob)}) provided as part of apply() call"
Expand Down Expand Up @@ -226,8 +242,9 @@ def get_historical_features(
>>> model.fit(feature_data) # insert your modeling framework here.
"""

registry = self._get_registry()
all_feature_views = registry.list_feature_views(project=self.config.project)
all_feature_views = self._registry.list_feature_views(
project=self.config.project
)
feature_views = _get_requested_feature_views(feature_refs, all_feature_views)
offline_store = get_offline_store_for_retrieval(feature_views)
job = offline_store.get_historical_features(
Expand Down Expand Up @@ -263,14 +280,15 @@ def materialize_incremental(
>>> )
"""
feature_views_to_materialize = []
registry = self._get_registry()
if feature_views is None:
feature_views_to_materialize = registry.list_feature_views(
feature_views_to_materialize = self._registry.list_feature_views(
self.config.project
)
else:
for name in feature_views:
feature_view = registry.get_feature_view(name, self.config.project)
feature_view = self._registry.get_feature_view(
name, self.config.project
)
feature_views_to_materialize.append(feature_view)

# TODO paging large loads
Expand Down Expand Up @@ -316,14 +334,15 @@ def materialize(
>>> )
"""
feature_views_to_materialize = []
registry = self._get_registry()
if feature_views is None:
feature_views_to_materialize = registry.list_feature_views(
feature_views_to_materialize = self._registry.list_feature_views(
self.config.project
)
else:
for name in feature_views:
feature_view = registry.get_feature_view(name, self.config.project)
feature_view = self._registry.get_feature_view(
name, self.config.project
)
feature_views_to_materialize.append(feature_view)

# TODO paging large loads
Expand Down Expand Up @@ -416,8 +435,9 @@ def _get_online_features(
entity_keys.append(_entity_row_to_key(row))
result_rows.append(_entity_row_to_field_values(row))

registry = self._get_registry()
all_feature_views = registry.list_feature_views(project=self.config.project)
all_feature_views = self._registry.list_feature_views(
project=self.config.project, allow_cache=True
)

grouped_refs = _group_refs(feature_refs, all_feature_views)
for table, requested_features in grouped_refs:
Expand Down
Loading