Use timestamp check for token refresh #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
pyalex
and removed request for
woop and
jklegar
terryyylim
force-pushed
the
refresh-oauth-token
branch
from
63b5c36
to
0b20299
Compare
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
terryyylim
force-pushed
the
refresh-oauth-token
branch
from
0b20299
to
6ca95c1
Compare
|
/retest |
pyalex
approved these changes
Apr 9, 2021
|
/lgtm |
|
/approve |
woop
approved these changes
Apr 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
terryyylim
added a commit
that referenced
this pull request
Apr 9, 2021
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence Lim terencelimxp@gmail.com
What this PR does / why we need it:
Currently, auth id_token will expire after an hour. When auth is switched on, JobService which connects to Core Client will face authentication issues because of expired id_token. This PR validates if tokens are expired when requests hit Core and refreshes if they are.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: