Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path option to cli #1509

Merged
merged 1 commit into from
May 13, 2021
Merged

Add path option to cli #1509

merged 1 commit into from
May 13, 2021

Conversation

tedhtchang
Copy link
Contributor

@tedhtchang tedhtchang commented Apr 27, 2021

Signed-off-by: ted chang htchang@us.ibm.com

What this PR does / why we need it:
Specify a feature repo path using feat --chdir path-to-a-feature-repository COMMAND ..
Which issue(s) this PR fixes:
Possibly Fixes #1507

Does this PR introduce a user-facing change?:
yes

The --chdir or -c option allows users to run a feast command outside of a feature repo directory. 

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdk/python/feast/cli.py Outdated Show resolved Hide resolved
@woop
Copy link
Member

woop commented Apr 27, 2021

Thanks @tedhtchang, can we maybe get a single test to confirm that this functionality works?

@woop woop added the kind/feature New feature or request label Apr 27, 2021
@tedhtchang tedhtchang requested a review from a team as a code owner April 28, 2021 00:25
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedhtchang
To complete the pull request process, please assign tsotnet after the PR has been reviewed.
You can assign the PR to them by writing /assign @tsotnet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedhtchang
Copy link
Contributor Author

tedhtchang commented Apr 28, 2021

@tsotnet How do I find out what failed in the linter / lint-python check ? Never mind the lint-python check showed up now.

@tedhtchang tedhtchang force-pushed the cli-path-option branch 3 times, most recently from f404e86 to 8052e53 Compare April 29, 2021 01:26
@tedhtchang tedhtchang requested review from woop and removed request for a team April 29, 2021 01:32
Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang
Copy link
Contributor Author

Thanks @tedhtchang, can we maybe get a single test to confirm that this functionality works?
@woop Sure. I added a test.

@woop
Copy link
Member

woop commented Apr 29, 2021

@tsotnet How do I find out what failed in the linter / lint-python check ? Never mind the lint-python check showed up now.

For future reference, make lint and make format can be used to check linting locally and reformat the code.

@woop woop merged commit 77a7975 into feast-dev:master May 13, 2021
woop pushed a commit that referenced this pull request May 19, 2021
Signed-off-by: ted chang <htchang@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run feast cli command without cd into feature repo directory
4 participants