Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example description #1555

Closed
wants to merge 1 commit into from
Closed

Improve example description #1555

wants to merge 1 commit into from

Conversation

theofpa
Copy link
Contributor

@theofpa theofpa commented May 12, 2021

What this PR does / why we need it:
Improve the get_online_features description in the hello-world example.

Which issue(s) this PR fixes:

Fixes #1544

@theofpa theofpa requested review from jklegar, tsotnet, woop and a team as code owners May 12, 2021 20:02
@feast-ci-bot
Copy link
Collaborator

@theofpa: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: theofpa
To complete the pull request process, please assign jklegar after the PR has been reviewed.
You can assign the PR to them by writing /assign @jklegar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @theofpa. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>
@woop
Copy link
Member

woop commented May 13, 2021

Thanks for this @theofpa. We're busy moving these examples out of the main repository since they are built for Feast 0.9. I'll be creating a new repository with the examples shortly.

Added them here: https://github.com/feast-dev/feast-spark-examples

@woop woop closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants