Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contention issue #1582

Merged
merged 6 commits into from
May 25, 2021
Merged

Fix contention issue #1582

merged 6 commits into from
May 25, 2021

Conversation

woop
Copy link
Member

@woop woop commented May 24, 2021 •
edited
Loading

What this PR does / why we need it:

  • Disables unnecessary indexing in Datastore
  • Provides ability to set concurrency (amount of threads to use) as well as batch sizes being written

Which issue(s) this PR fixes:

Fixes #1575

Does this PR introduce a user-facing change?:

Added a write_concurrency option to Datastore

@woop woop requested review from jklegar, tsotnet and a team as code owners May 24, 2021 18:34
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021 •
edited
Loading

Codecov Report

Merging #1582 (13dce6f) into master (dfb029d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   83.59%   83.60%   +0.01%     
==========================================
  Files          65       65              
  Lines        5753     5757       +4     
==========================================
+ Hits         4809     4813       +4     
  Misses        944      944
Flag Coverage Δ
integrationtests 83.51% <100.00%> (+0.01%) ⬆️
unittests 77.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/gcp.py 84.12% <100.00%> (+0.25%) ⬆️
sdk/python/feast/repo_config.py 95.37% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb029d...13dce6f. Read the comment docs.

woop added 5 commits May 24, 2021 14:35
@woop
Disable indexing
f663e35 
Signed-off-by: Willem Pienaar <git@willem.co>
@woop
Add option to set datastore write concurrency
319db88 
Signed-off-by: Willem Pienaar <git@willem.co>
@woop
Add batch size configuration
46796fa 
Signed-off-by: Willem Pienaar <git@willem.co>
@woop
Ensure only positive integers
7eb67d1 
Signed-off-by: Willem Pienaar <git@willem.co>
@woop
Fix lint
13dce6f 
Signed-off-by: Willem Pienaar <git@willem.co>
@woop woop added the kind/bug label May 24, 2021
tsotnet
tsotnet reviewed May 24, 2021
View reviewed changes
Copy link
Collaborator

@tsotnet tsotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have these parameters be used in a test case

sdk/python/feast/infra/gcp.py
Comment on lines +47 to +48
self._write_concurrency = config.online_store.write_concurrency
self._write_batch_size = config.online_store.write_batch_size
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move these up by 2 lines so that online store & offline store code are logically grouped

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase gone wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@woop
Reorder code
e6c63e1 
Signed-off-by: Willem Pienaar <git@willem.co>
@tsotnet
Copy link
Collaborator

tsotnet commented May 24, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit 69a1d16 into feast-dev:master May 25, 2021
jklegar pushed a commit that referenced this pull request May 27, 2021
@woop @jklegar
Fix contention issue (#1582)
1818042 
* Disable indexing

Signed-off-by: Willem Pienaar <git@willem.co>

* Add option to set datastore write concurrency

Signed-off-by: Willem Pienaar <git@willem.co>

* Add batch size configuration

Signed-off-by: Willem Pienaar <git@willem.co>

* Ensure only positive integers

Signed-off-by: Willem Pienaar <git@willem.co>

* Fix lint

Signed-off-by: Willem Pienaar <git@willem.co>

* Reorder code

Signed-off-by: Willem Pienaar <git@willem.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsotnet tsotnet tsotnet approved these changes

@jklegar jklegar Awaiting requested review from jklegar

Assignees

@tsotnet tsotnet

Labels
approved kind/bug lgtm release-note size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Materialization into Datastore leads to contention error
4 participants
@woop @codecov-commenter @tsotnet @feast-ci-bot