-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contention issue #1582
Fix contention issue #1582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
==========================================
+ Coverage 83.59% 83.60% +0.01%
==========================================
Files 65 65
Lines 5753 5757 +4
==========================================
+ Hits 4809 4813 +4
Misses 944 944
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
cc3ddeb
to
13dce6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have these parameters be used in a test case
self._write_concurrency = config.online_store.write_concurrency | ||
self._write_batch_size = config.online_store.write_batch_size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move these up by 2 lines so that online store & offline store code are logically grouped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase gone wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Willem Pienaar <git@willem.co>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Disable indexing Signed-off-by: Willem Pienaar <git@willem.co> * Add option to set datastore write concurrency Signed-off-by: Willem Pienaar <git@willem.co> * Add batch size configuration Signed-off-by: Willem Pienaar <git@willem.co> * Ensure only positive integers Signed-off-by: Willem Pienaar <git@willem.co> * Fix lint Signed-off-by: Willem Pienaar <git@willem.co> * Reorder code Signed-off-by: Willem Pienaar <git@willem.co>
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1575
Does this PR introduce a user-facing change?: