Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check validity of event timestamp in ValidateFeatureRowDoFn #164

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

pradithya
Copy link
Collaborator

@pradithya pradithya commented Mar 28, 2019

Add validity check to event timestamp of a Feature Row so that it could be safely discarded during data validation check.

Fix #163

@thirteen37
Copy link
Collaborator

/approve

@zhilingc
Copy link
Collaborator

/lgtm

@pradithya
Copy link
Collaborator Author

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya, thirteen37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 5b6c7db into feast-dev:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants