Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to offline/online stores to specify supported upstream sources #1662

Closed
wants to merge 2 commits into from

Conversation

achals
Copy link
Member

@achals achals commented Jun 23, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

We need a way for Online and Offline stores to be explicit about what upstream sources are supported. This was added in #1552 but removed in #1649. This PR adds it back in.

Does this PR introduce a user-facing change?:

NONE

…urces

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #1662 (0635221) into master (2013c04) will decrease coverage by 12.08%.
The diff coverage is 74.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1662       +/-   ##
===========================================
- Coverage   84.05%   71.97%   -12.09%     
===========================================
  Files          72       71        -1     
  Lines        6273     6247       -26     
===========================================
- Hits         5273     4496      -777     
- Misses       1000     1751      +751     
Flag Coverage Δ
integrationtests ?
unittests 71.97% <74.28%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 31.06% <0.00%> (-0.31%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 31.18% <75.00%> (-55.88%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 95.83% <75.00%> (-1.01%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 31.66% <75.00%> (-47.33%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.08% <75.00%> (-61.88%) ⬇️
sdk/python/feast/infra/online_stores/sqlite.py 94.04% <75.00%> (-2.34%) ⬇️
sdk/python/feast/repo_config.py 93.49% <84.61%> (-2.91%) ⬇️
sdk/python/tests/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/online_read_write_test.py 20.00% <0.00%> (-80.00%) ⬇️
sdk/python/tests/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2013c04...0635221. Read the comment docs.

Comment on lines +56 to +59
@abstractmethod
def supports_offline_store(self, offline_store: Any) -> bool:
...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does online store need to define which offline stores to support? The online store and offline store do no interact with each other directly.

I'd say let providers define which online store & offline store they support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does online store need to define which offline stores to support? The online store and offline store do no interact with each other directly.

I'd say let providers define which online store & offline store they support.

Spoke offline - I'm going to scrap this PR because there's no explicitly unsupported combination at the moment. We should wait until the need for this kind of API emerges, possibly after we have an AWS provider.

@achals achals closed this Jun 23, 2021
@achals achals deleted the achal/supported-upstream-api branch June 23, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants