Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python to Feast list[int] mapping #1700

Closed
wants to merge 1 commit into from

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Jul 10, 2021

Corrects a case where if elements in list were not numpy types
type mapping would fail.

What this PR does / why we need it:
Fixes case where type mapping failed (in my case from Parquet FileSource)
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Corrects a case where if elements in list were not `numpy` types
type mapping would fail.
@judahrand judahrand requested review from achals, tsotnet, woop and a team as code owners July 10, 2021 10:22
@feast-ci-bot
Copy link
Collaborator

@judahrand: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: judahrand
To complete the pull request process, please assign jklegar after the PR has been reviewed.
You can assign the PR to them by writing /assign @jklegar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@judahrand
Copy link
Member Author

Fixes an issue mentioned in #1640 but not the whole issue as this still does not deal with empty lists.

@judahrand
Copy link
Member Author

/assign @jklega

@feast-ci-bot
Copy link
Collaborator

@judahrand: GitHub didn't allow me to assign the following users: jklega.

Note that only feast-dev members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jklega

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Jul 11, 2021

This is great @judahrand!

I'd love to merge this PR, but unfortunately it will probably be blocked by the lack of a test that ensures all our types are working. That isn't really your fault, it's just a technical debt in the project. We still need to write a test that runs through all the types.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #1700 (c0b1e57) into master (b3c0cce) will decrease coverage by 13.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1700       +/-   ##
===========================================
- Coverage   82.75%   69.73%   -13.02%     
===========================================
  Files          76       74        -2     
  Lines        6754     6664       -90     
===========================================
- Hits         5589     4647      -942     
- Misses       1165     2017      +852     
Flag Coverage Δ
integrationtests ?
unittests 69.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/type_map.py 41.09% <ø> (-1.37%) ⬇️
sdk/python/tests/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/online_read_write_test.py 20.00% <0.00%> (-80.00%) ⬇️
sdk/python/tests/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-61.61%) ⬇️
sdk/python/tests/test_cli_aws.py 40.74% <0.00%> (-59.26%) ⬇️
sdk/python/tests/test_cli_redis.py 40.74% <0.00%> (-59.26%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 30.37% <0.00%> (-51.90%) ⬇️
sdk/python/tests/test_cli_local.py 50.00% <0.00%> (-50.00%) ⬇️
sdk/python/tests/test_partial_apply.py 50.00% <0.00%> (-50.00%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c0cce...c0b1e57. Read the comment docs.

@adchia
Copy link
Collaborator

adchia commented Sep 3, 2021

Wanted to follow up here. I believe this was already fixed in the main repo (presumably after this PR), so closing this. Thanks again though for adding the fix! We added some basic tests for types, but still a work in progress.

@adchia adchia closed this Sep 3, 2021
@judahrand judahrand deleted the int-list branch September 17, 2021 18:46
@judahrand judahrand restored the int-list branch September 17, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants