Stringify WhichOneof to make mypy happy #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Shah <achals@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1705 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 76 76
Lines 6754 6754
=======================================
Hits 5589 5589
Misses 1165 1165
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
woop
approved these changes
Jul 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8bit-pixies
pushed a commit
to 8bit-pixies/feast
that referenced
this pull request
Jul 16, 2021
Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Something in our deps seems to have broken lint.
https://github.com/feast-dev/feast/runs/3034670734?check_suite_focus=true
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: