Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dry_run bug that was making to_bigquery hang indefinitely #1706

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

codyjlin
Copy link
Contributor

Signed-off-by: Cody Lin codyl@twitter.com

What this PR does / why we need it:
In PR #1661, I accidentally switched the order of the dry_run output and _block_until_done (these lines) in BigQueryRetrievalJob.to_bigquery that was making any dry_run call to hang. I fix it here.

Which issue(s) this PR fixes:

(Not large enough for issue)

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Cody Lin <codyl@twitter.com>
@feast-ci-bot
Copy link
Collaborator

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyjlin
Copy link
Contributor Author

/kind bug

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #1706 (f23b4fc) into master (0d2179d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          76       76           
  Lines        6754     6754           
=======================================
  Hits         5589     5589           
  Misses       1165     1165           
Flag Coverage Δ
integrationtests 82.67% <0.00%> (ø)
unittests 69.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 76.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2179d...f23b4fc. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, codyjlin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 0d0492d into feast-dev:master Jul 12, 2021
@codyjlin codyjlin deleted the fix-dry-run branch July 12, 2021 21:19
8bit-pixies pushed a commit to 8bit-pixies/feast that referenced this pull request Jul 16, 2021
…dev#1706)

Signed-off-by: Cody Lin <codyl@twitter.com>
Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants