Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to offline and online store specs in docs summary #1715

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jul 16, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@tsotnet tsotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #1715 (319ab5b) into master (8287b56) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
+ Coverage   84.27%   84.45%   +0.17%     
==========================================
  Files          78       78              
  Lines        6907     6984      +77     
==========================================
+ Hits         5821     5898      +77     
  Misses       1086     1086              
Flag Coverage Δ
integrationtests 84.37% <ø> (+0.17%) ⬆️
unittests 69.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/tests/test_offline_online_store_consistency.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8287b56...319ab5b. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit 20e0783 into feast-dev:master Jul 16, 2021
@achals achals deleted the achal/update-summary branch July 16, 2021 20:58
8bit-pixies pushed a commit to 8bit-pixies/feast that referenced this pull request Jul 16, 2021
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants