Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test warnings related to file_url #1726

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

tedhtchang
Copy link
Contributor

@tedhtchang tedhtchang commented Jul 21, 2021

Signed-off-by: ted chang htchang@us.ibm.com

What this PR does / why we need it:
Fix the test warning feast/sdk/python/feast/infra/offline_stores/file_source.py:48: UserWarning: Argument "file_url" is being deprecated. Please use the "path" argument.

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #1726 (89ac9db) into master (13645c1) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
+ Coverage   78.66%   78.77%   +0.10%     
==========================================
  Files          77       77              
  Lines        6502     6529      +27     
==========================================
+ Hits         5115     5143      +28     
+ Misses       1387     1386       -1     
Flag Coverage Δ
integrationtests 78.69% <100.00%> (+0.10%) ⬆️
unittests 62.21% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/data_source_utils.py 100.00% <ø> (ø)
...alization/test_offline_online_store_consistency.py 100.00% <100.00%> (ø)
...sts/integration/registration/test_feature_store.py 100.00% <100.00%> (ø)
...on/tests/integration/registration/test_registry.py 100.00% <100.00%> (ø)
...k/python/feast/infra/offline_stores/file_source.py 85.91% <0.00%> (-2.82%) ⬇️
sdk/python/feast/registry.py 79.86% <0.00%> (-0.96%) ⬇️
...gration/offline_store/test_historical_retrieval.py 99.09% <0.00%> (+<0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13645c1...89ac9db. Read the comment docs.

Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang
Copy link
Contributor Author

/cc @achals

@feast-ci-bot feast-ci-bot removed the request for review from a team July 22, 2021 01:37
@achals
Copy link
Member

achals commented Jul 22, 2021

Thanks @tedhtchang ! Looks good to me. The PR title mentions pandas.utils.testing but I don't see any changes related to that here?

@tedhtchang tedhtchang changed the title Fix unit test warnings related to file_url and panda.utils.testing Fix unit test warnings related to file_url Jul 22, 2021
@tedhtchang
Copy link
Contributor Author

Thanks @tedhtchang ! Looks good to me. The PR title mentions pandas.utils.testing but I don't see any changes related to that here?

Sorry I changed it. The title was old.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tedhtchang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 5c7c240 into feast-dev:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants