Return same type string for warehouse and serving NoOp stores #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can we use this noop warehouse/serving store? do we need to create a storage spec with type "noop" and reference it from feature spec? or we can just leave the datastore reference in feature spec empty? |
pradithya
approved these changes
Jan 2, 2019
zhilingc
approved these changes
Jan 2, 2019
Yanson
pushed a commit
to Yanson/feast
that referenced
this pull request
Jul 29, 2020
Performs ingestion of 20k items for 2 data science scenarios: Product Computer Vision features (20K/day - generated once a day) Product Text Attributes (20K/day - generated once a day) Fixes KE-647
dmartinol
pushed a commit
to dmartinol/feast
that referenced
this pull request
Jun 24, 2024
Parametrized tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #5
If the core api was to return a store spec with "noop" as it's type, then ingestion will ignore data sent to that store.