Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the datastore online_read method to be slightly more efficient #1819

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Refactor the datastore online_read method to be slightly more efficient #1819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97402a2
Refactor the datastore online_read method to be slightly more efficient
achals Aug 31, 2021
a960eee
Remove double import
achals Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions sdk/python/feast/infra/online_stores/datastore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,22 +243,21 @@ def online_read(
)
keys.append(key)

# NOTE: get_multi doesn't return values in the same order as the keys in the request.
# Also, len(values) can be less than len(keys) in the case of missing values.
values = client.get_multi(keys)

if values is not None:
keys_missing_from_response = set(keys) - set([v.key for v in values])
values = sorted(values, key=lambda v: keys.index(v.key))
for value in values:
values_dict = {v.key: v for v in values} if values is not None else {}
for key in keys:
if key in values_dict:
value = values_dict[key]
res = {}
for feature_name, value_bin in value["values"].items():
val = ValueProto()
val.ParseFromString(value_bin)
res[feature_name] = val
result.append((value["event_ts"], res))
for missing_key_idx in sorted(
[keys.index(k) for k in keys_missing_from_response]
):
result.insert(missing_key_idx, (None, None))
else:
result.append((None, None))

return result

Expand Down