Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update historical retrieval integration test for on demand feature views #1836

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 3, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Tests are good

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1836 (01fa222) into master (1044745) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1836      +/-   ##
==========================================
+ Coverage   84.04%   84.13%   +0.09%     
==========================================
  Files          90       90              
  Lines        6761     6770       +9     
==========================================
+ Hits         5682     5696      +14     
+ Misses       1079     1074       -5     
Flag Coverage Δ
integrationtests 84.06% <100.00%> (+0.09%) ⬆️
unittests 63.48% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 100.00% <100.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 100.00% <100.00%> (ø)
.../integration/online_store/test_universal_online.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/utils/aws_utils.py 88.46% <0.00%> (+0.11%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 82.06% <0.00%> (+0.68%) ⬆️
sdk/python/feast/infra/provider.py 88.98% <0.00%> (+0.84%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 97.34% <0.00%> (+0.88%) ⬆️
sdk/python/feast/infra/offline_stores/redshift.py 90.99% <0.00%> (+0.90%) ⬆️
...python/feast/infra/offline_stores/offline_store.py 85.36% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1044745...01fa222. Read the comment docs.

feast_objects = []
feast_objects.extend(feature_views.values())
feast_objects.extend([odfv, driver(), customer()])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still want this to test online retrieval no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, because it's part of feature_views.values()

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b0f38ad into feast-dev:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants