Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow support for on demand feature views #1853

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 11, 2021

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:
Support on demand transforms for the to_arrow method in offline retrieval

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #1853 (73579b0) into master (1b809a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1853   +/-   ##
=======================================
  Coverage   84.87%   84.88%           
=======================================
  Files          91       91           
  Lines        6961     6965    +4     
=======================================
+ Hits         5908     5912    +4     
  Misses       1053     1053           
Flag Coverage Δ
integrationtests 84.80% <100.00%> (+<0.01%) ⬆️
unittests 63.20% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 81.94% <100.00%> (ø)
sdk/python/feast/infra/offline_stores/file.py 97.43% <100.00%> (ø)
...python/feast/infra/offline_stores/offline_store.py 87.50% <100.00%> (+2.13%) ⬆️
sdk/python/feast/infra/offline_stores/redshift.py 90.99% <100.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 99.09% <100.00%> (-0.03%) ⬇️
...s/integration/registration/test_universal_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b809a7...73579b0. Read the comment docs.

@achals achals added compat/breaking Breaking user-facing change and removed compat/breaking Breaking user-facing change labels Sep 13, 2021
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@achals
Copy link
Member

achals commented Sep 13, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 0d0bdf2 into feast-dev:master Sep 13, 2021
@adchia adchia deleted the arrowSupport branch September 15, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants