Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide FeatureViewProjections from user interface & have FeatureViews carry FVProjections that carries the modified info of the FeatureView #1899

Merged
merged 17 commits into from
Oct 5, 2021
Merged

Hide FeatureViewProjections from user interface & have FeatureViews carry FVProjections that carries the modified info of the FeatureView #1899

merged 17 commits into from
Oct 5, 2021

Commits on Sep 22, 2021

  1. Revised FeatureService class and proto 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    0e802f4 View commit details
    Browse the repository at this point in the history

  2. wip transitioning feast off of FVProjections 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f17b075 View commit details
    Browse the repository at this point in the history

  3. corrected a lot of errors and tests failures 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e24d04a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. fix unit test failure and most lint issues 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    ffe284a View commit details
    Browse the repository at this point in the history

  2. remove debugging print statement 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    37b6d87 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. simplified _group_feature_refs 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    2971740 View commit details
    Browse the repository at this point in the history

  2. deleted FeatureViewProjection files 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    86b3665 View commit details
    Browse the repository at this point in the history

  3. code review fix and test fix 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    afc07d5 View commit details
    Browse the repository at this point in the history

  4. Correction in cli.py 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    dfdf35e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Made fixes to still get objects from registry but potentially modify … 

    …those objects after

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    9e00be5 View commit details
    Browse the repository at this point in the history

  2. fix merge conflicts 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    35411b3 View commit details
    Browse the repository at this point in the history

  3. fixed lint oopsie & added to docstring on feature reference string co… 

    …nvention

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    e69ad89 View commit details
    Browse the repository at this point in the history

  4. fixed merge conflicts 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    bf8eb94 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Brought back FVProjections without exposing it ever to user-facing API 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    009edf4 View commit details
    Browse the repository at this point in the history

  2. Updated OnDemandFV to this new paradigm. Other misc updates 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    d65326d View commit details
    Browse the repository at this point in the history

  3. corrections based on integration test failures 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    659374a View commit details
    Browse the repository at this point in the history

  4. corrections based on CR comments 

    Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
    @mavysavydav
    mavysavydav committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    31cd6a8 View commit details
    Browse the repository at this point in the history