Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feast endpoint #1927

Merged
merged 6 commits into from
Oct 7, 2021
Merged

Feast endpoint #1927

merged 6 commits into from
Oct 7, 2021

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR adds the feast endpoint command that allows users to query for the endpoint of their feature server.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Adds the `feast endpoint` CLI command

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #1927 (eb2f8f1) into master (a5b8c26) will decrease coverage by 22.36%.
The diff coverage is 33.33%.

❗ Current head eb2f8f1 differs from pull request most recent head e4fdeb7. Consider uploading reports for the commit e4fdeb7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1927       +/-   ##
===========================================
- Coverage   82.31%   59.95%   -22.37%     
===========================================
  Files          96       96               
  Lines        7499     7542       +43     
===========================================
- Hits         6173     4522     -1651     
- Misses       1326     3020     +1694     
Flag Coverage Δ
integrationtests ?
unittests 59.95% <33.33%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/aws.py 21.71% <23.52%> (-19.91%) ⬇️
sdk/python/feast/cli.py 38.69% <36.36%> (-0.10%) ⬇️
sdk/python/feast/infra/provider.py 84.16% <50.00%> (-6.52%) ⬇️
sdk/python/feast/feature_store.py 75.99% <66.66%> (-18.38%) ⬇️
.../integration/online_store/test_universal_online.py 14.58% <0.00%> (-85.42%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 18.69% <0.00%> (-80.49%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b8c26...e4fdeb7. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, couple of questions

sdk/python/feast/cli.py Outdated Show resolved Hide resolved
sdk/python/feast/version.py Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a0918bf into feast-dev:master Oct 7, 2021
@felixwang9817 felixwang9817 deleted the feast_endpoint branch October 7, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants