Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows registering of features in request data as RequestFeatureView. Refactors common logic into a BaseFeatureView class #1931

Merged
merged 26 commits into from
Oct 15, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Oct 11, 2021

What this PR does / why we need it:
Introduces a new kind of feature view called RequestFeatureView, which allows for discovery of features available only at request time. This refactors common logic of feature views into a BaseFeatureView class

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Allows registering of request data as a feature view via RequestFeatureView

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #1931 (c64a452) into master (0212728) will decrease coverage by 2.08%.
The diff coverage is 81.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
- Coverage   82.26%   80.17%   -2.09%     
==========================================
  Files          96       99       +3     
  Lines        7669     8158     +489     
==========================================
+ Hits         6309     6541     +232     
- Misses       1360     1617     +257     
Flag Coverage Δ
integrationtests 74.29% <81.84%> (+0.14%) ⬆️
unittests 59.57% <53.41%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/errors.py 70.00% <ø> (ø)
...python/feast/infra/offline_stores/offline_store.py 87.50% <ø> (ø)
...ts/integration/feature_repos/repo_configuration.py 93.18% <ø> (-6.82%) ⬇️
sdk/python/feast/cli.py 38.51% <16.66%> (-0.19%) ⬇️
sdk/python/feast/repo_operations.py 43.82% <25.00%> (-0.40%) ⬇️
...fline_store/test_universal_historical_retrieval.py 65.10% <66.66%> (-34.18%) ⬇️
sdk/python/feast/base_feature_view.py 77.77% <77.77%> (ø)
sdk/python/feast/registry.py 80.43% <80.00%> (-0.63%) ⬇️
sdk/python/feast/feature_store.py 91.34% <88.57%> (-3.21%) ⬇️
sdk/python/feast/feature_service.py 81.15% <100.00%> (+0.27%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0212728...c64a452. Read the comment docs.

@adchia adchia linked an issue Oct 11, 2021 that may be closed by this pull request
protos/feast/core/RequestFeatureView.proto Outdated Show resolved Hide resolved
sdk/python/feast/base_feature_view.py Show resolved Hide resolved
sdk/python/feast/base_feature_view.py Outdated Show resolved Hide resolved
sdk/python/feast/base_feature_view.py Show resolved Hide resolved
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
sdk/python/feast/errors.py Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_view.py Outdated Show resolved Hide resolved
@adchia adchia force-pushed the request_fv branch 3 times, most recently from 67b4612 to 9793233 Compare October 14, 2021 20:59
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

super nitty commends

sdk/python/feast/cli.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
…trieval

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit f5f5500 into feast-dev:master Oct 15, 2021
@adchia adchia deleted the request_fv branch October 27, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in apply_total
5 participants