Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BigQuery load jobs #1935

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Oct 13, 2021

What this PR does / why we need it:
A few weeks ago I contributed #1889 which fixed ARRAY columns in BigQuery. However, it added a fairly ugly workaround. I've fixed this upstream and it is available in the latest release of google-cloud-bigquery: googleapis/python-bigquery#980.

I thought it would make sense to simplify this in Feast by using the latest version.

Does this PR introduce a user-facing change?:

Update `google-cloud-bigquery` dependency to more simply handle list features.

@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

:lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia
Copy link
Collaborator

adchia commented Oct 13, 2021

/lgtm

@judahrand
Copy link
Member Author

Sorry @adchia - realised we should also be requiring PyArrow>=4.0.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #1935 (fd6b582) into master (df724a8) will decrease coverage by 22.53%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1935       +/-   ##
===========================================
- Coverage   81.89%   59.36%   -22.54%     
===========================================
  Files          97       97               
  Lines        7756     7739       -17     
===========================================
- Hits         6352     4594     -1758     
- Misses       1404     3145     +1741     
Flag Coverage Δ
integrationtests ?
unittests 59.36% <20.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 31.51% <0.00%> (-48.60%) ⬇️
sdk/python/tests/utils/data_source_utils.py 55.17% <0.00%> (-44.83%) ⬇️
...n/feature_repos/universal/data_sources/bigquery.py 38.09% <50.00%> (-59.53%) ⬇️
.../integration/online_store/test_universal_online.py 14.39% <0.00%> (-84.85%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 17.73% <0.00%> (-81.57%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <0.00%> (-63.27%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df724a8...fd6b582. Read the comment docs.

@adchia
Copy link
Collaborator

adchia commented Oct 13, 2021

/ok-to-test

@adchia
Copy link
Collaborator

adchia commented Oct 13, 2021

/lgtm

@achals
Copy link
Member

achals commented Oct 13, 2021

/lgtm

@achals
Copy link
Member

achals commented Oct 15, 2021

@judahrand looks like this is ready to land barring a merge conflict - let us know if you need any help!

@judahrand
Copy link
Member Author

judahrand commented Oct 15, 2021

@judahrand looks like this is ready to land barring a merge conflict - let us know if you need any help!

@achals Should be sorted!

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand
Copy link
Member Author

@achals Failure doesn't look like my fault

@adchia
Copy link
Collaborator

adchia commented Oct 15, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 6b10a82 into feast-dev:master Oct 15, 2021
felixwang9817 pushed a commit that referenced this pull request Oct 28, 2021
* Simplify BigQuery load jobs

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

* Ensure `pyarrow` supports `use_compliant_nested_type`

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants