Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test cli in prow script not returning correct exit code #206

Merged
merged 3 commits into from
May 30, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented May 29, 2019

Previously, when running unit test for CLI, the return code is the return code of the "tee" command NOT the "test" command. Hence it was always successful and we might miss failing Feast CLI unit tests.

Previously, after piping and calling tee, the return code is the return code of tee not the test command, which is not what we want
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator Author

/test unit-test-cli

@feast-ci-bot
Copy link
Collaborator

@davidheryanto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
unit-test-cli f945355 link /test unit-test-cli

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidheryanto
Copy link
Collaborator Author

davidheryanto commented May 29, 2019

NOTE:
OK for unit-test-cli to fail in this pull request.
Need to fix that in another pull request.

@zhilingc
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants