Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to compute ODFVs when there are no ODFVs #2090

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Nov 25, 2021

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR ensures that we do not attempt to compute ODFVs in RetrievalJobs when there are no ODFVs.

Which issue(s) this PR fixes:

Fixes #2072

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #2090 (c8e0fc3) into master (54d0f3a) will decrease coverage by 25.35%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2090       +/-   ##
===========================================
- Coverage   83.44%   58.09%   -25.36%     
===========================================
  Files         100      100               
  Lines        8077     8077               
===========================================
- Hits         6740     4692     -2048     
- Misses       1337     3385     +2048     
Flag Coverage Δ
integrationtests ?
unittests 58.09% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 33.13% <0.00%> (-48.26%) ⬇️
sdk/python/feast/infra/offline_stores/redshift.py 41.46% <0.00%> (-45.53%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 88.80% <100.00%> (-8.00%) ⬇️
...python/feast/infra/offline_stores/offline_store.py 72.91% <100.00%> (-14.59%) ⬇️
.../integration/online_store/test_universal_online.py 15.34% <0.00%> (-82.80%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d0f3a...c8e0fc3. Read the comment docs.

@felixwang9817 felixwang9817 changed the title Remove option for on_demand_feature_views to be None in RetrievalJob [WIP] Remove option for on_demand_feature_views to be None in RetrievalJob Nov 25, 2021
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title [WIP] Remove option for on_demand_feature_views to be None in RetrievalJob Do not attempt to compute ODFVs when there are no ODFVs Nov 30, 2021
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Dec 2, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit ce84d38 into feast-dev:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent logic with on_demand_feature_views
4 participants