Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden google-cloud-core dependency #2094

Merged

Conversation

ptoman-pa
Copy link
Contributor

What this PR does / why we need it:
Broadens dependency on google-cloud-core. The limitation to 1.4.* seems tighter than it needs to be. The version 1.7.2 (which is the latest before 2.0.0) passes unit tests and makes feast more interoperable as a library with other systems.

Which issue(s) this PR fixes:
Relates to #928

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @ptoman-pa. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #2094 (2aa2256) into master (455176f) will decrease coverage by 9.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2094      +/-   ##
==========================================
- Coverage   83.45%   73.95%   -9.51%     
==========================================
  Files         100       98       -2     
  Lines        8088     8020      -68     
==========================================
- Hits         6750     5931     -819     
- Misses       1338     2089     +751     
Flag Coverage Δ
integrationtests 73.95% <ø> (+0.05%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/unit/test_usage.py 13.86% <0.00%> (-86.14%) ⬇️
...ion/test_cli_apply_duplicated_featureview_names.py 14.54% <0.00%> (-85.46%) ⬇️
...n/tests/integration/registration/test_cli_chdir.py 18.51% <0.00%> (-81.49%) ⬇️
.../python/tests/integration/scaffolding/test_init.py 18.91% <0.00%> (-81.09%) ⬇️
sdk/python/tests/unit/test_proto_json.py 21.05% <0.00%> (-78.95%) ⬇️
sdk/python/feast/proto_json.py 18.18% <0.00%> (-77.28%) ⬇️
sdk/python/tests/doctest/test_all.py 16.36% <0.00%> (-76.37%) ⬇️
...ts/integration/scaffolding/test_repo_operations.py 24.07% <0.00%> (-75.93%) ⬇️
...n/tests/integration/online_store/test_e2e_local.py 24.48% <0.00%> (-75.52%) ⬇️
.../tests/integration/scaffolding/test_repo_config.py 37.20% <0.00%> (-62.80%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455176f...2aa2256. Read the comment docs.

@felixwang9817
Copy link
Collaborator

hey @ptoman-pa, thanks for your PR! we require PRs to be signed; would you mind signing your commit and rebasing? thanks!

@ptoman-pa
Copy link
Contributor Author

@felixwang9817 Thank you for the polite reminder! Signed.

@felixwang9817
Copy link
Collaborator

hey @ptoman-pa, I don't think the signing worked properly. if you look at your commit, you'll see it doesn't have the "signed off by" note that other commits have - could you try signing again with git commit -s? thanks!

@ptoman-pa ptoman-pa force-pushed the loosen-google-core-dependencies branch 2 times, most recently from ddde51e to d6cca6a Compare December 1, 2021 20:08
@ptoman-pa
Copy link
Contributor Author

Done. Also added a note about the project wanting signoffs rather than GPG, but we can remove that or break it into a separate PR depending on your preferences for repo management.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@felixwang9817
Copy link
Collaborator

thanks for adding that note to our docs @ptoman-pa! it looks like the first of two commits is signed off properly, but the second isn't - would you mind fixing that? apologies for all the back and forth!

ptoman-pa and others added 2 commits December 2, 2021 07:35
Limiting google-cloud-core to 1.4.* seems tighter than it needs to be. The version 1.7.2 (which is the latest before 2.0.0) passes tests and makes feast more interoperable as a library with other systems.

Signed-off-by: Pamela Toman <ptoman@paloaltonetworks.com>
Signed-off-by: Pamela Toman <ptoman@paloaltonetworks.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, ptoman-pa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit c7d0b10 into feast-dev:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants