Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand raw column to accomodate more features ingested in one go #213

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

budi
Copy link
Contributor

@budi budi commented Jun 13, 2019

When trying to ingest a lot of features in one go, core complains about data integrity, saying that entry is too long for type character varying(4096)

{  
   "timeMillis":1560409069190,
   "thread":"grpc-default-executor-52",
   "level":"ERROR",
   "loggerName":"feast.core.grpc.JobServiceImpl",
   "message":"Error in submitJob: {}",
   "thrown":{  
      "commonElementCount":0,
      "localizedMessage":"Error running ingestion job: org.springframework.dao.DataIntegrityViolationException: could not execute statement; SQL [n/a]; nested exception is org.hibernate.exception.DataException: could not execute statement",
      "message":"Error running ingestion job: org.springframework.dao.DataIntegrityViolationException: could not execute statement; SQL [n/a]; nested exception is org.hibernate.exception.DataException: could not execute statement",
      "name":"feast.core.exception.JobExecutionException",
      "cause":{  
         "commonElementCount":14,
         "localizedMessage":"could not execute statement; SQL [n/a]; nested exception is org.hibernate.exception.DataException: could not execute statement",
         "message":"could not execute statement; SQL [n/a]; nested exception is org.hibernate.exception.DataException: could not execute statement",
         "name":"org.springframework.dao.DataIntegrityViolationException",
         "cause":{  
            "commonElementCount":14,
            "localizedMessage":"could not execute statement",
            "message":"could not execute statement",
            "name":"org.hibernate.exception.DataException",
            "cause":{  
               "commonElementCount":14,
               "localizedMessage":"ERROR: value too long for type character varying(4096)",
               "message":"ERROR: value too long for type character varying(4096)",
               "name":"org.postgresql.util.PSQLException",
...

Changing the limit to 40960 as a temporary solution.

@budi budi requested a review from pradithya June 13, 2019 09:01
@budi budi requested review from tims and zhilingc as code owners June 13, 2019 09:01
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: budi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@budi
Copy link
Contributor Author

budi commented Jun 13, 2019

/retest

@davidheryanto
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 8a6b2fc into feast-dev:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants