Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamodb infra object #2131

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR adds DynamoDB tables as InfraObjects.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817 felixwang9817 requested a review from a team as a code owner December 10, 2021 01:30
@felixwang9817 felixwang9817 requested review from mavysavydav and removed request for a team December 10, 2021 01:30
@felixwang9817 felixwang9817 requested review from achals and removed request for mavysavydav December 10, 2021 01:30
@felixwang9817 felixwang9817 added kind/feature New feature or request ok-to-test and removed size/L labels Dec 10, 2021
@felixwang9817 felixwang9817 assigned achals and unassigned tsotnet Dec 10, 2021
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #2131 (2b8765a) into master (50f29cd) will decrease coverage by 25.44%.
The diff coverage is 32.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2131       +/-   ##
===========================================
- Coverage   83.37%   57.92%   -25.45%     
===========================================
  Files         101      101               
  Lines        8133     8162       +29     
===========================================
- Hits         6781     4728     -2053     
- Misses       1352     3434     +2082     
Flag Coverage Δ
integrationtests ?
unittests 57.92% <32.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/dynamodb.py 35.89% <29.78%> (-55.02%) ⬇️
sdk/python/feast/infra/infra_object.py 57.50% <100.00%> (ø)
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
.../integration/online_store/test_universal_online.py 15.34% <0.00%> (-82.33%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f29cd...2b8765a. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Dec 13, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 192d3ad into feast-dev:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants