Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rollback API for providers #2149

Closed
wants to merge 1 commit into from

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Dec 15, 2021

What this PR does / why we need it:
Addresses the issue mentioned. This is very much a first pass solution so keen for any and all feedback.

Which issue(s) this PR fixes:

Fixes #2116

Does this PR introduce a user-facing change?:

None

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand judahrand requested a review from a team as a code owner December 15, 2021 10:43
@judahrand judahrand requested review from achals and removed request for a team December 15, 2021 10:43
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: judahrand
To complete the pull request process, please assign achals after the PR has been reviewed.
You can assign the PR to them by writing /assign @achals in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@judahrand
Copy link
Member Author

The AWS failures make it a bit tricky to tell that this is working as intended. I'm not sure how to proceed on that front.

@felixwang9817
Copy link
Collaborator

@judahrand thanks for this PR! we believe we've fixed most of the issues with AWS integration tests (we increased the size of our Redshift cluster for tests and found a bug here that kept leaking Dynamo tables), so we're hoping the tests are fine going forward (we still expect occasional leakages until this issue has been resolved, but they should be very manageable)

as for the rollback API, we're still considering whether it should be supported, but for now since tests should be fine, let's put a hold on this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feast apply can leak resources and create inconsistent state
4 participants