Updates to click==8.*

[diogommartins]

What this PR does / why we need it:
Updates click from 7.x to 8.x - https://click.palletsprojects.com/en/8.0.x/upgrading/

NONE

[feast-ci-bot]

Hi @diogommartins. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adchia]

Thanks for the PR! Mind signing the commit to pass the DCO check?

[codecov-commenter]

Codecov Report

Merging #2210 (3d3cc41) into master (36c1d46) will decrease coverage by 11.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2210       +/-   ##
===========================================
- Coverage   84.40%   73.30%   -11.11%     
===========================================
  Files         104      103        -1     
  Lines        8247     8158       -89     
===========================================
- Hits         6961     5980      -981     
- Misses       1286     2178      +892     

Flag	Coverage Δ
integrationtests	73.30% <ø> (-1.17%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ion/test_cli_apply_duplicated_featureview_names.py	14.54% <0.00%> (-85.46%)	⬇️
sdk/python/tests/unit/test_usage.py	14.78% <0.00%> (-85.22%)	⬇️
sdk/python/tests/unit/diff/test_fco_diff.py	16.66% <0.00%> (-83.34%)	⬇️
...n/tests/integration/registration/test_cli_chdir.py	18.51% <0.00%> (-81.49%)	⬇️
.../python/tests/integration/scaffolding/test_init.py	18.91% <0.00%> (-81.09%)	⬇️
sdk/python/tests/unit/test_proto_json.py	19.64% <0.00%> (-80.36%)	⬇️
sdk/python/feast/proto_json.py	18.18% <0.00%> (-77.28%)	⬇️
...ts/integration/scaffolding/test_repo_operations.py	24.07% <0.00%> (-75.93%)	⬇️
...n/tests/integration/online_store/test_e2e_local.py	24.48% <0.00%> (-75.52%)	⬇️
sdk/python/tests/doctest/test_all.py	15.51% <0.00%> (-74.14%)	⬇️
... and 59 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c1d46...3d3cc41. Read the comment docs.

[diogommartins]

Thanks for the PR! Mind signing the commit to pass the DCO check?

Done it!

/assign @tsotnet

[adchia]

/ok-to-test

[adchia]

will also need to update the pip-tools requirements files: https://github.com/feast-dev/feast/tree/master/sdk/python/requirements

[diogommartins]

will also need to update the pip-tools requirements files: https://github.com/feast-dev/feast/tree/master/sdk/python/requirements

will do

[woop]

Is there any reason to only support a single major version?

[diogommartins]

Is there any reason to only support a single major version?

Since there isn't an interface change from 7.x and 8.x, I don't see a reason not to support both. I fixed the version to 8.x to follow the previous design decision 🤷‍♂️

[adchia]

this seems fine to me. we can keep this unless someone else feels strongly.

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, diogommartins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment