Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference of BigQuery ARRAY types. #2245

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Jan 27, 2022

What this PR does / why we need it:

BigQuery arrays are currently handled incorrectly for many cases in feature type inference.

This PR is a subset of #2028. Some of the other issues that PR dealt with have subsequently been fixed.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix inference of BigQuery ARRAY types.

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand judahrand requested a review from a team as a code owner January 27, 2022 11:28
@judahrand judahrand requested review from achals and removed request for a team January 27, 2022 11:28
@judahrand judahrand added the kind/feature New feature or request label Jan 27, 2022
@judahrand judahrand changed the title Bq array Support more BigQuery ARRAY types Jan 27, 2022
@judahrand judahrand changed the title Support more BigQuery ARRAY types Fix inference of BigQuery ARRAY types. Jan 27, 2022
@judahrand judahrand added kind/bug and removed kind/feature New feature or request labels Jan 27, 2022
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judahrand this change looks good! do you mind adding a test in test_inference.py? it looks like none of the tests in there are testing bigquery (or redshift) type inference

@judahrand
Copy link
Member Author

judahrand commented Feb 1, 2022

@judahrand this change looks good! do you mind adding a test in test_inference.py? it looks like none of the tests in there are testing bigquery (or redshift) type inference

@felixwang9817 I kinda feel like if I do that it is certain to uncover more broken things and this PR will balloon. Do you think the testing should be a separate PR? This isn't making it worse as it is already broken 😛

@felixwang9817
Copy link
Collaborator

felixwang9817 commented Feb 1, 2022

@judahrand that seems reasonable - would appreciate if you could send out a follow up PR (not urgent) with a test! will lgtm

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 7c53177 into feast-dev:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants