Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -SNAPSHOT suffix to pom.xml version #2286

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Feb 5, 2022

Signed-off-by: Tsotne Tabidze tsotne@tecton.ai

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #2286 (e2234bf) into master (3b36334) will increase coverage by 27.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2286       +/-   ##
===========================================
+ Coverage   58.60%   86.01%   +27.41%     
===========================================
  Files         116      116               
  Lines        9810     9810               
===========================================
+ Hits         5749     8438     +2689     
+ Misses       4061     1372     -2689     
Flag Coverage Δ
integrationtests 74.80% <ø> (?)
unittests 58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 60.55% <0.00%> (+0.39%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 95.27% <0.00%> (+1.57%) ⬆️
sdk/python/feast/errors.py 70.51% <0.00%> (+3.20%) ⬆️
sdk/python/feast/online_response.py 77.77% <0.00%> (+3.70%) ⬆️
sdk/python/feast/feature.py 90.24% <0.00%> (+4.87%) ⬆️
sdk/python/feast/infra/provider.py 89.16% <0.00%> (+5.00%) ⬆️
...k/python/feast/infra/offline_stores/file_source.py 89.21% <0.00%> (+6.86%) ⬆️
sdk/python/feast/utils.py 100.00% <0.00%> (+10.00%) ⬆️
sdk/python/feast/dqm/profilers/profiler.py 81.25% <0.00%> (+10.41%) ⬆️
sdk/python/feast/repo_config.py 88.82% <0.00%> (+11.73%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36334...e2234bf. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817,tsotnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit f18c514 into feast-dev:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants