Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in markdown files #2289

Merged
merged 1 commit into from
Feb 6, 2022
Merged

fix typos in markdown files #2289

merged 1 commit into from
Feb 6, 2022

Conversation

8bit-pixies
Copy link
Contributor

@8bit-pixies 8bit-pixies commented Feb 5, 2022

What this PR does / why we need it:

Fixes typos in docs

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #2289 (01038da) into master (3b36334) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
- Coverage   58.60%   58.55%   -0.05%     
==========================================
  Files         116      116              
  Lines        9810     9820      +10     
==========================================
+ Hits         5749     5750       +1     
- Misses       4061     4070       +9     
Flag Coverage Δ
unittests 58.55% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 44.44% <0.00%> (-0.93%) ⬇️
...s/integration/registration/test_universal_types.py 34.75% <0.00%> (-0.43%) ⬇️
sdk/python/feast/type_map.py 40.12% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 15.32% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36334...01038da. Read the comment docs.

@felixwang9817
Copy link
Collaborator

hey @charliec443 thanks for this PR! you'll have to sign your commits with git commit -s to pass the DCO check

Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
@chapman73
Copy link

Thanks @felixwang9817 should be done now

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charliec443, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Feb 6, 2022

Thanks @charliec443

@woop woop merged commit 023dc36 into feast-dev:master Feb 6, 2022
adchia pushed a commit that referenced this pull request Feb 6, 2022
Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants