-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix materialize bug with RedisCluster #2311
Conversation
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
===========================================
- Coverage 86.11% 58.50% -27.62%
===========================================
Files 116 116
Lines 9834 9933 +99
===========================================
- Hits 8469 5811 -2658
- Misses 1365 4122 +2757
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
…positives Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@adchia PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ents * upstream/master: (103 commits) refactor: Move create cluster script ci: Add validation for upper case PR titles Switch order of views to keep/delete to fix apply logging ci: Fix broken Prow plugin which ignores config.yaml ci: Add PR linting to ensure conventional commits are followed for PR titles Add owner field to FeatureService (feast-dev#2321) Disable Redis cluster tests (feast-dev#2327) Use PR title for commit message Add redis cluster initialziation to master github workflow (feast-dev#2317) Fix materialize bug with RedisCluster (feast-dev#2311) Add support for Dask during historical retrieval (feast-dev#1954) downgrade datatypes to 8 Update pom.xml to 0.18.2 SNAPSHOT Update changelog for 0.18.1 and update pom.xml Update helm chart version Don't require `snowflake` to always be installed (feast-dev#2309) Fixing the Java helm charts and adding a demo tutorial on how to use them (feast-dev#2298) Include infra objects in registry dump and fix Infra's from_proto (feast-dev#2295) Remove old flag warning with the python feature server (feast-dev#2300) podAnnotations Values in the feature-server chart (feast-dev#2304) ...
* Fix materialization bug Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * oops removed something when i was copy pasting Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Test github workflow Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * transfer to unit_tests Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Brute force implementation Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Brute force implementation add gcc Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Brute force implementation add gcc Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Brute force implementation add gcc Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Brute force implementation add gcc Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Continue fixing... Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Remove gcc setup Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Add integration test Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * fix error Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * fix error Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Add setup Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * temp fix to get integration tests to work Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * temp fix to get integration tests to work Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * temp fix to get integration tests to work Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * temp fix to get integration tests to work Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix integration even more Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix integration even more Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * only run one test Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Do some more integration testing Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Do some more integration testing by adding bug to make sure no false positives Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Integration testing works Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Clean upu code Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Add redis cluster script for starting a redis cluster Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Reset integration yml file Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Clean up Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix how to guide lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * add fixtures and remove excess code Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * lint Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang kzhang@tecton.ai
What this PR does / why we need it:
Broken materialization script for feast 0.18.0. Refer to issue #2297.
Issue was that there are 2 versions of the python redis cluster package redis-py-cluster and redis-py. redis-py only recently added a new version of RedisCluster and our api was using the redis-py-cluster api that passes dictionary of host:port pairs while redis-py implementation requires ClusterNodes instead.
Which issue(s) this PR fixes:
Fixes #2297
Does this PR introduce a user-facing change?:
Makes changes to integration github workflow that cannot be tested accurately since github runs the current PR against the current github workflow. Attached is proof that the new integration tests with the new workflow: