Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reorder feature view parameters #2455

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: #2440 mistakenly changed the order of the FeatureView parameters, which could potentially break users who are defining FeatureViews using positional arguments. This PR ensures that the order of the parameters does not change.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 requested a review from a team as a code owner March 25, 2022 21:04
@felixwang9817 felixwang9817 requested review from woop and removed request for a team March 25, 2022 21:04
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Mar 25, 2022

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #2455 (d4e937e) into master (4cbf97b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2455      +/-   ##
==========================================
- Coverage   84.74%   84.73%   -0.01%     
==========================================
  Files         126      126              
  Lines       10798    10798              
==========================================
- Hits         9151     9150       -1     
- Misses       1647     1648       +1     
Flag Coverage Δ
integrationtests 74.72% <ø> (-0.24%) ⬇️
unittests 58.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 91.05% <ø> (ø)
...ython/feast/embedded_go/online_features_service.py 95.08% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbf97b...d4e937e. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit ca7d616 into feast-dev:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants