Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Killing auto assign / auto review since they add noise #2546

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Apr 14, 2022

What this PR does / why we need it:
This removes the noisy auto-assign of PRs + issues (including auto reviewers).

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia requested a review from a team as a code owner April 14, 2022 20:10
@adchia adchia requested review from woop and removed request for a team April 14, 2022 20:10
@adchia adchia requested review from kevjumba and removed request for woop April 14, 2022 20:11
@kevjumba kevjumba assigned kevjumba and unassigned felixwang9817 Apr 14, 2022
@kevjumba
Copy link
Collaborator

/lgtm

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #2546 (92ad618) into master (1a00fdc) will decrease coverage by 23.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2546       +/-   ##
===========================================
- Coverage   81.49%   57.60%   -23.90%     
===========================================
  Files         141      140        -1     
  Lines       12011    11899      -112     
===========================================
- Hits         9788     6854     -2934     
- Misses       2223     5045     +2822     
Flag Coverage Δ
integrationtests ?
unittests 57.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-80.00%) ⬇️
.../integration/online_store/test_universal_online.py 15.09% <0.00%> (-77.50%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.88% <0.00%> (-76.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-74.20%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-67.91%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 33.92% <0.00%> (-66.08%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 35.36% <0.00%> (-63.42%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a00fdc...92ad618. Read the comment docs.

@felixwang9817 felixwang9817 merged commit 44f5c11 into feast-dev:master Apr 14, 2022
@adchia adchia deleted the removeAutomation branch July 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants