Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating quickstart and fixing roadmap + broken links to old alpha docs #2553

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Apr 15, 2022

What this PR does / why we need it:
This also updates some example repos to use source instead of batch_source

Which issue(s) this PR fixes:

Fixes #

…link to old alpha docs

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #2553 (3ee57d5) into master (1e398d9) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   81.58%   81.47%   -0.11%     
==========================================
  Files         141      141              
  Lines       11941    11941              
==========================================
- Hits         9742     9729      -13     
- Misses       2199     2212      +13     
Flag Coverage Δ
integrationtests 73.37% <ø> (-0.46%) ⬇️
unittests 57.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
.../integration/online_store/test_universal_online.py 94.84% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e398d9...3ee57d5. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -148,7 +148,7 @@ The list below contains the functionality that contributors are planning to deve
* [x] [Hive (community plugin)](https://github.com/baineng/feast-hive)
* [x] [Postgres (community plugin)](https://github.com/nossrannug/feast-postgres)
* [x] [Spark (community plugin)](https://docs.feast.dev/reference/data-sources/spark)
* [x] Kafka / Kinesis sources (via [push support into the online store](https://docs.feast.dev/reference/data-sources/push)
* [x] Kafka / Kinesis sources (via [push support into the online store](https://docs.feast.dev/reference/data-sources/push))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many parens

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 753bd88 into feast-dev:master Apr 15, 2022
adchia added a commit that referenced this pull request Apr 15, 2022
…lpha docs (#2553)

* chore: Updating quickstart and fixing trailing ) in roadmap + broken link to old alpha docs

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the fixDocs branch July 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants